[wp-trac] [WordPress Trac] #18887: Appearance -> Header UI: "Display Text" Needs Distinct theme_mod

WordPress Trac wp-trac at lists.automattic.com
Sun Oct 9 00:23:10 UTC 2011


#18887: Appearance -> Header UI: "Display Text" Needs Distinct theme_mod
--------------------------+------------------------------
 Reporter:  chipbennett   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  UI            |     Version:  3.2
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by chipbennett):

 Just a note that, while doing some testing of the new code, I'm still
 noticing an issue that results from the conflation of `header_textcolor`
 and `display_header_text`. If "Display Text" is set to `false`, and then
 changed to `true`, the `header_textcolor` displays as '''`#blank`''',
 which not only is semantically incorrect (the value is expected to be a
 valid, six-digit HEX color value), but also poor UX (the previous
 `header_textcolor` apparently isn't retained when "Display Text" is set to
 `false`).

 So, even after putting an intuitive `display_header_text()` around the
 `header_textcolor` hack, we've still not solved all of the non-intuitive
 UX issues.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18887#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list