[wp-trac] [WordPress Trac] #18880: Back compat for the admin_user_info_links filter

[WordPress Trac]

#18880: Back compat for the admin_user_info_links filter
--------------------------+-----------------------------------
 Reporter:  nacin         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  3.3
Component:  Plugins       |    Version:
 Severity:  normal        |   Keywords:  has-patch 2nd-opinion
--------------------------+-----------------------------------
 Brought up by otto42 in #18197, the admin_user_info_links filter is now
 gone.

 Given the backwards compatibility workarounds this filter required for the
 3.2 dropdown, I figured it couldn't be ''that'' difficult to push these
 into the admin bar.

 Warning, reading this patch may make you susceptible to nausea. It works.
 Um. Yeah. Definitely leaning toward wontfix. Was still quite fun to write.
 :-)

 I searched through the plugins directory and only found about a dozen
 plugins using the filter: two from otto42, one from dd32, one from
 mitcho*, a few admin simplification plugins, and a number of Howdy
 tweakers.

 The admin simplification plugins would need an update anyway, and we all
 love Howdy, so this further supports a death. So I'm inclined to post to
 wpdevel and contact each developer as well.

 One more note, this filter always kind of sucked. When it was introduced
 in 3.0, the bars separating the links were included in each link, rather
 than the links being imploded, and the link itself was raw HTML. (Note the
 fun regular expression in my patch.)

 Plugin directory scan results below:

 {{{
 /plugins/admin-trim-interface/admin-trim-interface.php:142:
 add_filter( 'admin_user_info_links',                   array( &$this,
 'admin_user_info_links' ) );
 ./plugins/admin-trim-interface/admin-trim-interface.php:206:    public
 function admin_user_info_links( $links ) {
 ./plugins/better-howdy/better-howdy.php:18:add_filter(
 'admin_user_info_links', 'better_howdy' );
 ./plugins/blog-id-in-site-admin-menu/blog-id-in-site-admin-menu.php:28:
 add_filter('admin_user_info_links','blog_id_in_howdy_greeting');
 ./plugins/dirtysuds-kill-
 howdy/howdy.php:31:add_filter('admin_user_info_links', 'dirtysuds_howdy');
 ./plugins/edit-howdy/edithowdy.php:206:add_filter(
 'admin_user_info_links', 'edithowdy_update_howdy_message', 9 );
 ./plugins/edit-howdy/edithowdy.php:209: * This function filters the
 admin_user_info_links function to apply our new Howdy message.
 ./plugins/howdy-tweaks/howdy-greeting-tweaks.php:33:
 add_filter( 'admin_user_info_links', array( &$this, 'the_info_tweaks' ) );
 ./plugins/quick-admin-color-scheme-picker/quick-admin-color-scheme-
 picker.php:9:add_action('admin_user_info_links', 'qacsp_link', 10, 1000);
 ./plugins/simple-facebook-connect/sfc-
 login.php:100:add_filter('admin_user_info_links','sfc_login_admin_header');
 ./plugins/simple-twitter-connect/stc-
 login.php:156:add_filter('admin_user_info_links','stc_login_admin_header');
 ./plugins/wp-simplify/wp-simplify.php:458:
 add_filter('admin_user_info_links',
 array('WP_Simplify','admin_user_info_links'), 0, 2);
 ./plugins/wp-simplify/wp-simplify.php:485:  function
 admin_user_info_links($links, $current_user) {
 ./plugins/wp-su/wp-su.php:57:           // 3.0+
 add_action('admin_user_info_links', array(&$this, 'admin_header_su'));
 }}}

 * For fun, test my patch with http://wordpress.org/extend/plugins/quick-
 admin-color-scheme-picker/ -- that's what necessitated the CSS changes.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18880>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software