[wp-trac] [WordPress Trac] #18525: zlib.output_compression "on" in server conflicts with autoupdate

[WordPress Trac]

#18525: zlib.output_compression "on" in server conflicts with autoupdate
------------------------------------+------------------------------
 Reporter:  avidre                  |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  General                 |     Version:  3.2.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------

Comment (by kurtpayne):

 Replying to [comment:9 dd32]:
 > The patch reverts [11020]
 Fixed.  Thanks.

 > Trunk will currently emmit a Notice: `Notice: ob_end_flush()
 [ref.outcontrol]: failed to delete buffer zlib output compression` when
 that function is called, your code/reverted code will produce it too, just
 hide it from display.
 I'm not able to reproduce this even using E_ALL.  What setup are you
 using?

 > Found a weird bug though, Opera can't handle the nullbytes.. or at
 least, not when it's part of the source, within HTML comment tags they're
 fine. I believe I've seen a similar bug for Safari, where a Null byte is
 on a chunk boundary, it can cause the rest of the page to be "lost" (just
 not rendered).

 Changed the patch to just emit `<!-- ->` a bunch of times instead.  I've
 seen different approaches to this ... some use one big html comment, some
 prefer whitespace, some use small comments, etc.
 [http://core.trac.wordpress.org/attachment/ticket/11289/ticket-11289-full.patch
 This patch] uses the alphabet.

 > also note, PHPDoc can't be parsed when it's inline like that I don't
 believe, so best to puts @links in the function docs rather than inline.

 Fixed.  Does WP generate documentation anywhere?  I thought these blocks
 made more sense to the reader inline, but I agree that phpdoc/docblox/etc.
 wouldn't pick up on them.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18525#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software