[wp-trac] [WordPress Trac] #19371: As of 3.3beta2 WP_Admin_Bar no longer provides a way to access attributes of existing menu items

WordPress Trac wp-trac at lists.automattic.com
Wed Nov 30 23:57:02 UTC 2011


#19371: As of 3.3beta2 WP_Admin_Bar no longer provides a way to access attributes
of existing menu items
------------------------------+-----------------------
 Reporter:  willshouse        |       Owner:  nacin
     Type:  defect (bug)      |      Status:  accepted
 Priority:  high              |   Milestone:  3.3
Component:  Admin Bar         |     Version:  3.3
 Severity:  minor             |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------

Comment (by nacin):

 Replying to [comment:21 willshouse]:
 > Ok, if that's the case I'm not seeing where scribu's changes are being
 included in the latest - 19371.5.diff. For example if I take the current
 version in the trunk and apply the 19371.5.diff patch I'm still seeing
 that the `remove_menu` function does not return the node that is being
 removed:
 >
 > {{{
 > public function remove_menu( $id ) {
 >       $this->remove_node( $id );
 > }
 > }}}

 There's a return missing. Easy fix.
 >
 > Is that a mistake that needs to be added into the latest diff or am I
 missing another way of editing the existing menu attributes?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19371#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list