[wp-trac] [WordPress Trac] #19370: Default 'Search' input on Toolbar is off by about 6pixels on Safari

WordPress Trac wp-trac at lists.automattic.com
Wed Nov 30 23:47:17 UTC 2011


#19370: Default 'Search' input on Toolbar is off by about 6pixels on Safari
-------------------------------------+------------------
 Reporter:  Ipstenu                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  3.3
Component:  Admin Bar                |     Version:  3.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by koopersmith):

 Thanks for the screenshots, Sergey, they helped immensely.

 I really dislike the fact that the placeholder's baseline cannot remain
 consistent cross-browser.

 With #19404 in mind, I've attached a patch that makes the search trigger
 an icon only. This solves a few problems:

 1. We don't have to worry about the placeholder.
 2. We don't have to fix the width of the menu item (which looks awkward
 and is currently in place because we can't predict the length of the
 translated placeholder string.

 Another alternative would be to have the search box pop down when the item
 is pressed (like shortlink does now). This would prevent the expanded
 search item from pushing toolbar items to the next line of a crowded bar.
 If we go in this direction, we could optionally include text in the item
 as well (and avoid baseline issues).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19370#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list