[wp-trac] [WordPress Trac] #19399: New uploader doesn't show if the options for large image sizes are not numbers
WordPress Trac
wp-trac at lists.automattic.com
Wed Nov 30 19:29:55 UTC 2011
#19399: New uploader doesn't show if the options for large image sizes are not
numbers
--------------------------+---------------------
Reporter: westi | Owner: azaozz
Type: defect (bug) | Status: new
Priority: high | Milestone: 3.3
Component: Upload | Version: 3.3
Severity: major | Resolution:
Keywords: has-patch |
--------------------------+---------------------
Comment (by nacin):
We can't use ctype_digit(), as it's not available everywhere.
I think absint() is sufficient. We do it all over the place to fine
effect. A bit of sanitization followed by validating that it is not 0 (if
such a value is invalid in that context).
sanitize_option() sanitizes all of these options with absint() anyway,
which leads me to A) wonder how westi did this :-) and B) not at all care
about this beyond the JS error and empty/0 values.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/19399#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list