[wp-trac] [WordPress Trac] #19189: thickbox.js .trigger("unload") causes conflicts

WordPress Trac wp-trac at lists.automattic.com
Fri Nov 25 16:57:21 UTC 2011

#19189: thickbox.js .trigger("unload") causes conflicts
 Reporter:  ocean90         |       Owner:  azaozz
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  3.3
Component:  Administration  |     Version:  3.3
 Severity:  major           |  Resolution:  fixed
 Keywords:  has-patch       |

Comment (by azaozz):

 Replying to [comment:25 aesqe]:
 > ...sorry for bugging so much, but this is driving me crazy :(

 Not your fault, sorry I didn't explain it better above.
 `jQuery('#TB_window').unload...` will only work after thickbox is opened
 (#TB_window exists in the DOM), `jQuery(document).on('unload',
 '#TB_window',...` is not going to work since we trigger the 'unload' with
 triggerHandler that doesn't propagate. These are not solutions for the
 problem, more like possible ideas to try to make it work.

 Unfortunately the only way to stay back-compat here seems to be to revert
 this change and fix any improperly triggered `window.unload` on a case by
 case basis. This is **"the last nail"** for thickbox, we either have to
 completely remove any use of it from core or replace it with better script
 in 3.4.

Ticket URL: <http://core.trac.wordpress.org/ticket/19189#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list