[wp-trac] [WordPress Trac] #19320: wp_tiny_mce() cannot call wp_editor(), and other issues
WordPress Trac
wp-trac at lists.automattic.com
Tue Nov 22 07:54:51 UTC 2011
#19320: wp_tiny_mce() cannot call wp_editor(), and other issues
-----------------------------+------------------
Reporter: nacin | Owner:
Type: defect (bug) | Status: new
Priority: highest omg bbq | Milestone: 3.3
Component: Editor | Version:
Severity: blocker | Resolution:
Keywords: |
-----------------------------+------------------
Comment (by markjaquith):
It's an odd class, that's for sure. It has instance variables, but to
output a new editor, no new instance is created, the instance variables
are just changed. It would make a lot more sense as an actual class with a
separate instance for each editor. And either static methods or a
{{{WP_Editor_Factory}}} singleton to control the global stuff that needs
to happen. But I don't think we can get into all that now.
I'd like to prioritize the following goals:
* Backwards compatibility. Let's not break plugins.
* Making sure no one can use this class in its current state. I'd go
beyond the admonishment in the file and actually force it to be a
singleton. That way we can clean it up in a subsequent release. It's not
meant to be reused, so let's make sure it can't be.
* Public APIs that don't box us in.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/19320#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list