[wp-trac] [WordPress Trac] #19155: Remove scrollbar and max-height from help tabs

[WordPress Trac]

#19155: Remove scrollbar and max-height from help tabs
----------------------------+--------------------------
 Reporter:  ocean90         |       Owner:  koopersmith
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  3.3
Component:  Administration  |     Version:  3.3
 Severity:  normal          |  Resolution:  fixed
 Keywords:                  |
----------------------------+--------------------------
Changes (by koopersmith):

 * keywords:  ui-feedback =>
 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 I agree with Jane here — in this case, there's no benefit to the
 animation, only delay. As for consistency, most of our other tabs and
 features that shift box heights change instantly. The animation when
 opening screen options/help is the exception, not the rule.

 I'm going to close this ticket as fixed.

 Replying to [comment:11 olleicua]:
 > I was trying to look into this just now but it seems the fix has been
 committed since It works correctly (although without animation). Did
 someone refactor this without posting here..?

 Yes, instead of the JS patch, I reworked it to use CSS as mentioned in
 [http://core.trac.wordpress.org/ticket/19155#comment:8 comment 8] and
 implemented in [19361] (shown here in
 [http://core.trac.wordpress.org/ticket/19155#comment:9 comment 9]).

 The help columns are arranged in a way that will increase the height of
 the help container to the height of the tallest column (regardless of that
 column's height), so code to calculate the column height is unnecessary.

 The tricky part here was getting the three columns to each appear to
 stretch to the bottom of the help container. That is now accomplished by
 an absolutely positioned div that sits behind the three columns and paints
 the middle column/borders.

 Replying to [comment:19 olleicua]:
 > That makes sense, sorry I'm new.

 Trac keywords definitely take some getting used to. We use them to manage
 our workflow — you'll get the hang of them soon. :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19155#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software