[wp-trac] [WordPress Trac] #19092: Inactive sidebar box can be on the wrong place in one situation

[WordPress Trac]

#19092: Inactive sidebar box can be on the wrong place in one situation
--------------------------+-----------------------
 Reporter:  ocean90       |       Owner:  azaozz
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  3.3
Component:  Widgets       |     Version:  3.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by lancewillett):

 Replying to [comment:20 azaozz]:
 > > Also causes a notice:
 > > {{{
 > > NOTICE: wp-includes/widgets.php:1244 - Undefined index:
 wp_inactive_widgets
 > > }}}
 >
 > Seems the notice comes from the fact that 'wp_inactive_widgets' hasn't
 been registered yet. Can add that by hand to `$sidebars`. Strangely didn't
 see that notice while testing.

 I saw the error after your commit in r19332, and the latest patch fixes
 it.

 > > Wouldn't [attachment:19092.patch] be the proper solution here?
 >
 > 19092.2.patch threats the saved data as "main" and looks for orphaned
 widgets in it. Not sure that's the proper behavior. If the saved data for
 a theme doesn't match the current theme's setup, think we should be
 discarding it, not appending to orphaned.

 I disagree. This goes against the point of the Orphaned widgets idea.
 Nothing should go into Inactive unless it's moved there explicitly.

 The consensus in #17979 was that we'd save the data for previous themes
 indefinitely -- and that data trumps anything new when you switch back.

 See notes in http://core.trac.wordpress.org/ticket/19291#comment:5.

 At that time I'd argued to remove the stored data after a week. But that
 was overruled by the core team. :)

 I think on WP.com we might end up only storing it for a week. If a theme
 is switched back after that time, we'll just treat it as a new theme, not
 on old one you're going back to.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19092#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software