[wp-trac] [WordPress Trac] #19291: Widgets move to Inactive after clearing all widgets from sidebars

[WordPress Trac]

#19291: Widgets move to Inactive after clearing all widgets from sidebars
------------------------------+------------------------------
 Reporter:  lancewillett      |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Warnings/Notices  |     Version:  3.3
 Severity:  normal            |  Resolution:
 Keywords:                    |
------------------------------+------------------------------

Comment (by lancewillett):

 Replying to [comment:3 azaozz]:
 > Replying to [comment:2 lancewillett]:
 > 19092.2.patch treats the previous theme's saved data as the "main" data
 which seems undesirable. The "main" data is the data from the previous
 theme, not the saved data from some time ago.

 This is what Aaron and I set out to do in #17979. We're treating the saved
 data as canonical, and moving anything else to Orphaned widgets.

 So the patch is correct in that sense.

 Replying to [comment:4 azaozz]:
 > Replying to [ticket:19291 lancewillett]:
 > > This only happens if you remove *all* widgets from all sidebars.
 >
 > This border case is interesting. When switching themes we do not save
 widgets instances/settings. We only save widgets positions in the
 sidebars.
 >
 > In that case IMHO we should be adding all of the newly added widgets to
 Inactive Widgets.

 Please, no. :)

 We want to avoid moving anything to Inactive if possible. Remap to new
 sidebar is 1st priority, which works in all cases but this one.

 Second priority is to move to Orphaned.

 My goal is to not ever see anything in Inactive unless a user moves it
 there.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19291#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software