[wp-trac] [WordPress Trac] #18331: Make get_header(), get_sidebar() and get_footer() use get_template_part()

WordPress Trac wp-trac at lists.automattic.com
Fri Nov 18 00:02:29 UTC 2011


#18331: Make get_header(), get_sidebar() and get_footer() use get_template_part()
------------------------------+----------------------
 Reporter:  Viper007Bond      |       Owner:
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:
Component:  Template          |     Version:  3.2.1
 Severity:  normal            |  Resolution:  wontfix
 Keywords:  has-patch commit  |
------------------------------+----------------------

Comment (by nacin):

 Including a file twice can result in a fatal error pretty easily, so
 warning them wouldn't help much. You basically have to rely on
 require_once(), which get_template_part() deliberately avoids using.
 ?
 Any abstraction will require either another parameter or some conditional
 check for header/footer/sidebar, neither of which is particularly neat and
 enough for me to come out and say wontfix.

 I'm annoyed I didn't catch this first time through as I had been down this
 path before..

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18331#comment:36>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list