[wp-trac] [WordPress Trac] #19131: setting $taxnow in POSTS
WordPress Trac
wp-trac at lists.automattic.com
Thu Nov 17 19:42:54 UTC 2011
#19131: setting $taxnow in POSTS
----------------------------+-----------------------
Reporter: haayman | Owner: ryan
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 3.3
Component: Administration | Version: 3.2.1
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+-----------------------
Comment (by nacin):
Replying to [comment:11 ryan]:
> This no longer sets _GET[ 'post_type'] to the derived post type. I
don't think the lack hurts anything.
Agreed. Our penchant to hack stuff into $_GET and $_REQUEST bugs the heck
out of me.
> Instead of $typenow, standardize on get_current_screen()->post_type?
Definitely. I started using it here and looked at killing off usage. It's
why there's an otherwise unnecessary `$post_type = $typenow;`, that way it
wouldn't appear in my greps.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/19131#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list