[wp-trac] [WordPress Trac] #19092: Inactive sidebar box can be on the wrong place in one situation

WordPress Trac wp-trac at lists.automattic.com
Thu Nov 17 00:28:16 UTC 2011


#19092: Inactive sidebar box can be on the wrong place in one situation
--------------------------+------------------
 Reporter:  ocean90       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.3
Component:  Widgets       |     Version:  3.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by azaozz):

 Replying to [comment:8 nacin]:
 > I have a feeling that when you introduce child themes into the mix,
 things get messy quickly.

 Agreed, changing to another theme and then back to the previous theme but
 this time with a child theme (that changes the number of sidebars) would
 make the saved data bad. Perhaps we should invalidate the data in this
 case and threat the old theme + child theme as a new/different theme.

 > I made a theme change on a site in the wild, and suddenly I had a bunch
 of inactive sidebar boxes, but all of them but one of them were empty.

 This sounds like another bug. As far as I see it there shouldn't be any
 empty inactive sidebars at all.

 > Also, the inactive sidebar description needs some work, it doesn't read
 right, and the title doesn't fit, so all you see is "Inactive Sidebar
 (from previous them".

 Maybe make the "(from previous theme)" a title/tooltip on "Inactive
 Sidebar"? We need to shorten it.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19092#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list