[wp-trac] [WordPress Trac] #18274: Add_query_arg doesn't cope with guid in url ie &p= becomes #038; p=

[WordPress Trac]

#18274: Add_query_arg doesn't cope with guid in url  ie &p= becomes #038;p=
--------------------------+----------------------
 Reporter:  anmari        |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  General       |     Version:  3.2.1
 Severity:  trivial       |  Resolution:  invalid
 Keywords:                |
--------------------------+----------------------
Changes (by nacin):

 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 add_query_arg() does not do any encoding. This only happens when you have
 encoded data going into add_query_arg() to begin with.

 nathanrice, your problem is that menu_page_url() was introduced with
 esc_url() on both return and echo. Not sure I like that behavior, but I'd
 suggest it is too late now. Perhaps we could esc_url_raw() for security
 and get away with only esc_url() when echo'ing. Please open a new ticket
 to change this behavior — this one is invalid.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18274#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software