[wp-trac] [WordPress Trac] #17177: Optimize parse_request for the home page (empty request)

WordPress Trac wp-trac at lists.automattic.com
Thu Nov 10 20:07:40 UTC 2011


#17177: Optimize parse_request for the home page (empty request)
----------------------------------------+-----------------------
 Reporter:  duck_                       |       Owner:  ryan
     Type:  defect (bug)                |      Status:  reopened
 Priority:  high                        |   Milestone:  3.3
Component:  Rewrite Rules               |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch commit 3.3-early  |
----------------------------------------+-----------------------

Comment (by duck_):

 Good catch, thanks.

 Not sure what happened between my original ticket where I mention
 `WP::$request` specifically and the patches which start checking $req_uri.
 I think we can just replace $req_uri with $request_match in the empty()
 call in the if-statement. I think this would be clearer than
 [attachment:request2.patch] (which also unnecessarily sets $request_match
 on every loop iteration) and, unlike [attachment:request.patch], use the
 correct variable name.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17177#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list