[wp-trac] [WordPress Trac] #19037: Patch for is_ssl, ssl_redirect and general http/https logic / bug

[WordPress Trac]

#19037: Patch for is_ssl, ssl_redirect and general http/https logic / bug
-------------------------+------------------------------
 Reporter:  MarcusPope   |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Security     |     Version:  3.2.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------------------

Comment (by MarcusPope):

 Thanks for the ecouraging remarks Nacin.  From a naming convention
 perspective I'm completely ignorant AND agnostic to wordpress standards on
 that front.  So, please take this with a grain of salt if necessary :D

 Since this function doesn't actually change the scheme in use, perhaps
 fix_url_scheme() would be more appropriate?  I think set_url_scheme would
 apply more towards a hybrid of ssl_redirect(), force_ssl_admin() and
 force_ssl_login() where you could set the scheme to be used for future
 requests.  As where this was/is designed to correct the url schemes of
 existing link generation functions based purely on the current request
 method.

 I'll totally leave this up to you guys though, just giving my outsider's
 perspective.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19037#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software