[wp-trac] [WordPress Trac] #11520: print_scripts_l10n() should use json_encode()

WordPress Trac wp-trac at lists.automattic.com
Tue Nov 8 04:48:51 UTC 2011


#11520: print_scripts_l10n() should use json_encode()
-------------------------+------------------------
 Reporter:  scribu       |       Owner:  azaozz
     Type:  enhancement  |      Status:  reviewing
 Priority:  normal       |   Milestone:  3.3
Component:  JavaScript   |     Version:
 Severity:  critical     |  Resolution:
 Keywords:               |
-------------------------+------------------------

Comment (by nacin):

 I really, really like [attachment:11520-5.patch]. Curious as to westi's
 opinion as well.

 There's a lot of changes, but it's grok-able. If we can't get this into
 3.3, what should we get into 3.3 in order to set us up for 3.4?

 I would like to see a diff that doesn't mess with the _doing_it_wrong()
 stuff. Ultimately, moving it into one function makes it more difficult to
 backtrace, and it really doesn't do *that* much to abstract things out. I
 know it's not very DRY, but still. :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11520#comment:82>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list