[wp-trac] [WordPress Trac] #19198: Die fast in get_posts if in_search_post_types returns nothing

WordPress Trac wp-trac at lists.automattic.com
Mon Nov 7 19:45:21 UTC 2011


#19198: Die fast in get_posts if in_search_post_types returns nothing
-----------------------------+-----------------------------
 Reporter:  mitchoyoshitaka  |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Query            |    Version:
 Severity:  minor            |   Keywords:  has-patch
-----------------------------+-----------------------------
 From a comment of mine in #18364, which nacin suggested was worth a
 follow-up ticket:

  Just noticed that this logic here might in fact have a flaw: if there are
 no post types which have exclude_from_search = false, then magically *all*
 post types will be checked? Am I reading this right? In that case,
 shouldn't we just immediately return no results?

  Obviously, this wouldn't be an issue except in a very customized setup
 where all post types have exclude_from_search = true, but still...
 thoughts anyone?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19198>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list