[wp-trac] [WordPress Trac] #18724: Non functioning 'paged' input on theme/plugin search

[WordPress Trac]

#18724: Non functioning 'paged' input on theme/plugin search
-------------------------------------+------------------
 Reporter:  kurtpayne                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  3.3
Component:  Administration           |     Version:  3.1
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------
Changes (by johnkleinschmidt):

 * cc: johnkleinschmidt (added)
 * keywords:  has-patch => has-patch needs-testing


Comment:

 The issue with ocean90's patch was that he removed/moved the form
 declarations from the '''install_theme_search_form''' function in ''wp-
 admin/includes/theme-install.php'' and the '''install_search_form
 function''' in ''wp-admin/includes/plugin-install.php''.  The reason this
 is a problem is that those functions actually get called two places:

 For themes:
 * '''install_themes_dashboard''' function in ''wp-admin/includes/theme-
 install.php''
 * fired from the '''install_themes_table_header''' action in ''wp-
 admin/includes/class-wp-theme-install-list-table.php''

 For plugins:
 * '''install_dashboard''' function in ''wp-admin/includes/plugin-
 install.php''
 * fired from the '''install_plugins_table_header''' action in ''wp-
 admin/includes/class-wp-plugin-install-list-table.php''

 ocean90's solution was to move the form declarations from the search_form
 functions to the code that fires the actions, but that means that when the
 dashboard functions get called they don't have the form declaration.

 My patch takes a different approach.  It seems to me to make more sense to
 leave the form declarations in the search_form functions and then to move
 the call to generate pagination within the search_form function.  Its a
 cleaner approach that avoids having to declare the form DOM elements
 twice.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18724#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software