[wp-trac] [WordPress Trac] #19122: Always show "My Sites", sometimes hide "Site Name" menu

[WordPress Trac]

#19122: Always show "My Sites", sometimes hide "Site Name" menu
--------------------------+-----------------------------------
 Reporter:  duck_         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  3.3
Component:  General       |    Version:  3.3
 Severity:  normal        |   Keywords:  has-patch 2nd-opinion
--------------------------+-----------------------------------
 Non-super-admin who is member of only one site visits a site they're not
 associated with.

  1. They see the "Site Name" menu and it's linked to the dashboard of the
 current site which they don't have access to
  1. No "My Sites" menu for quick access to dashboard of the user's site

 Point 1. can be fixed by hiding the "Site Name" site when the current blog
 ID isn't in the user's blogs array and they're not a super-admin.

 Point 2. proposed fixed is to always show the "My Sites" menu.

 Also stopped the removal of the current site from "My Sites" to fix issue
 of empty "My Sites" drop down. This could probably also be fixed by some
 more complicated logic earlier in the function, but the 'now it's here,
 now it isn't' nature seems a little strange to me.

 Related: #18197, #18990 (proposed fix would invalidate the latter)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19122>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software