[wp-trac] [WordPress Trac] #19091: After theme switch inactive box is filled with widgets which I haven't used

[WordPress Trac]

#19091: After theme switch inactive box is filled with widgets which I haven't used
--------------------------+------------------
 Reporter:  ocean90       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.3
Component:  Widgets       |     Version:  3.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-patch => has-patch
 * milestone:  Awaiting Review => 3.3


Comment:

 Doesn't happen if I manually remove them from "Inactive Widgets" area and
 try again.

 Widget options in this case are a bit different from the ones on a clean
 install:
 {{{
 (87, 0, 'widget_text', 'a:1:{s:12:"_multiwidget";i:1;}', 'yes'),
 (88, 0, 'widget_rss', 'a:1:{s:12:"_multiwidget";i:1;}', 'yes'),
 (106, 0, 'widget_pages', 'a:1:{s:12:"_multiwidget";i:1;}', 'yes'),
 (107, 0, 'widget_calendar', 'a:1:{s:12:"_multiwidget";i:1;}', 'yes'),
 (108, 0, 'widget_links', 'a:1:{s:12:"_multiwidget";i:1;}', 'yes'),
 (109, 0, 'widget_tag_cloud', 'a:1:{s:12:"_multiwidget";i:1;}', 'yes'),
 (110, 0, 'widget_nav_menu', 'a:1:{s:12:"_multiwidget";i:1;}', 'yes'),
 }}}

 On a clean install:
 {{{
 (87, 0, 'widget_text', 'a:2:{i:2;a:0:{}s:12:"_multiwidget";i:1;}', 'yes'),
 (88, 0, 'widget_rss', 'a:2:{i:2;a:0:{}s:12:"_multiwidget";i:1;}', 'yes'),
 (110, 0, 'widget_pages', 'a:2:{i:2;a:0:{}s:12:"_multiwidget";i:1;}',
 'yes'),
 (111, 0, 'widget_calendar', 'a:2:{i:2;a:0:{}s:12:"_multiwidget";i:1;}',
 'yes'),
 (112, 0, 'widget_links', 'a:2:{i:2;a:0:{}s:12:"_multiwidget";i:1;}',
 'yes'),
 (113, 0, 'widget_tag_cloud', 'a:2:{i:2;a:0:{}s:12:"_multiwidget";i:1;}',
 'yes'),
 (114, 0, 'widget_nav_menu', 'a:2:{i:2;a:0:{}s:12:"_multiwidget";i:1;}',
 'yes'),
 }}}

 My guess is that `wp_convert_widget_settings()` shouldn't run for all
 newly registered widgets (including core widgets), which happens now. This
 leads (as I see it) to single instances being treated as copies. Adding a
 patch.

 Related: [10784]

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19091#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software