[wp-trac] [WordPress Trac] #17399: Esc-key to close modal window in fullscreen mode, closes fullscreen mode.

[WordPress Trac]

#17399: Esc-key to close modal window in fullscreen mode, closes fullscreen mode.
--------------------------+------------------
 Reporter:  xibe          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.2
Component:  Editor        |     Version:  3.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------
Changes (by chrisbliss18):

 * cc: gaarai@… (added)
 * keywords:   => has-patch


Comment:

 Submitted the patch proposal 17399-fix.diff. I had to do some things that
 I'm not sure are acceptable to make it work.

 Key modifications:

  * Added a global scope JS variable wpDialogOpen. This is set to false by
 default in all code files that check it (just to make sure that whatever
 combination of code is run will have this set by default).
  * The Thickbox and TinyMCE wpDialog APIs were updated to set wpDialogOpen
 to true when they are opened and false when they are closed. When setting
 the wpDialogOpen variable to false, a timer of 100 ms is used to ensure
 that the fullscreen API's event handler can execute before the flag is
 cleared.
  * The fullscreen API's Esc key event handler was moved from keyup to
 keydown to keep it inline with how the Thickbox and TinyMCE wpDialog APIs
 use keydown event handlers. Without this modification, a lengthy timout or
 complex set of additional event handlers would have to be used to keep the
 wpDialogOpen flag updates and checks in the correct order.

 I considered using some combination of event registrations and handlers to
 observe when dialogs are open rather than the wpDialogOpen variable, but
 this would have required even larger modifications and would possibly
 introduce issues with code requiring APIs to be loaded just to handle this
 type of setup. This being the case, I opted for simplicity with minimal
 modifications and requirements.

 I'm not attached to the name of the variable, the presence of or duration
 of the settimeout, or really any of this code.

 This patch has been tested in Firefox 4.0.1 (Win 7 & Ubuntu 10.10),
 Chromium 12.0.742.30 (84361) (Ubuntu 10.10), Chrome 11.0.696.68 (Win 7),
 Opera 11.10 (Win 7 & Ubuntu 10.10), Safari 5.0.5 (7533.21.1) (Win 7), and
 IE 9.0.8112.16421 (Win 7). It worked properly in all browsers. IE 9 had
 some issues in fullscreen, but from my testing, this had nothing to do
 with my patch as removing my modifications didn't create different
 results.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17399#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software