[wp-trac] [WordPress Trac] #16920: PHP5-Port: Take out unnecessary compat functions from diverse files

[WordPress Trac]

#16920: PHP5-Port: Take out unnecessary compat functions from diverse files
-----------------------------------------+-----------------------
 Reporter:  hakre                        |       Owner:
     Type:  defect                       |      Status:  reopened
 Priority:  normal                       |   Milestone:  3.2
Component:  General                      |     Version:  3.1
 Severity:  normal                       |  Resolution:
 Keywords:  reporter-feedback has-patch  |
-----------------------------------------+-----------------------
Changes (by hakre):

 * keywords:  needs-patch => reporter-feedback has-patch


Comment:

 Replying to [comment:15 dd32]:
 > Ignore that.. Turns out there was some PHP4 comapt in there: (thanks
 ocean90)
 >
 > {{{
 > #!text/x-diff
 > - $zopen = $z->open($file, /* ZIPARCHIVE::CHECKCONS */ 4);
 > + $zopen = $z->open($file, ZIPARCHIVE::CHECKCONS);
 > }}}

 [http://www.php.net/manual/en/zip.installation.php php ZIPARCHIVE]
 constants are not automatically available, so not using the CONST does
 make still sense with PHP 5.2+.

 ----

 I think this ticket should be still reopend because of technosailor's
 findings. Patch looks good to me.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16920#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software