[wp-trac] [WordPress Trac] #16970: Remove PHP4 functionality from timezone selector code

[WordPress Trac]

#16970: Remove PHP4 functionality from timezone selector code
----------------------------+---------------------------
 Reporter:  Viper007Bond    |       Owner:  Viper007Bond
     Type:  defect (bug)    |      Status:  accepted
 Priority:  normal          |   Milestone:  3.2
Component:  Administration  |     Version:  3.1
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+---------------------------

Comment (by nacin):

 Replying to [comment:10 aaroncampbell]:
 > The patch looks fine.  Does exactly what Alex and I had first discussed.
 >
 > My issue is that Alex said he was going to do the patch since he hadn't
 contributed anything to core for a while.  What was the purpose of
 uploading a patch less than an hour after he said he would?  Did he ask
 you to (or did you ask him)?  If not, couldn't you have focused your time
 on another ticket (just offering input on this one like everyone else did)
 instead of stepping on someone's toes like that?

 I never want to discourage someone from contributing. But among the more
 active contributors, there's a bit of informal code about things like
 this. Those who have commented to this ticket, we all have the ability (in
 terms of skill) to contribute to basically any ticket. When someone says
 they want to tackle something, I'd think it'd be common courtesy would be
 to at least circle back, oh, more than 25 minutes later. Chances are Alex
 was working on the patch at the time.

 Given enough eyeballs, all bugs are shallow, but that doesn't mean it's a
 race or that duplicative efforts shouldn't be avoided when it isn't
 necessary. As Aaron says, certainly time could have been spent on another
 ticket.

 Again, I never want to discourage contributions. If it was a newer
 contributor who posted a patch, I would not want this conversation to take
 place. But among us, let's have some mutual respect please?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16970#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software