[wp-trac] [WordPress Trac] #13777: Consolidate WP_Http argument processing into a single class

[WordPress Trac]

#13777: Consolidate WP_Http argument processing into a single class
-------------------------+--------------------------
 Reporter:  jacobsantos  |       Owner:  jacobsantos
     Type:  enhancement  |      Status:  reopened
 Priority:  low          |   Milestone:
Component:  HTTP         |     Version:  3.0
 Severity:  minor        |  Resolution:
 Keywords:  has-patch    |
-------------------------+--------------------------
Changes (by jacobsantos):

 * status:  closed => reopened
 * resolution:  wontfix =>


Comment:

 Replying to [comment:5 dd32]:
 > I don't see any need for this.
 >
 > The WP_HTTP::request() method takes care of the incoming request and can
 handle processing the args. The processing of the args in each transport
 is specific to it's needs, to abstract the minimal code duplication will
 introduce more code and increase the churn rate of the existing code.

 Come again? Perhaps you should review the existing code and this patch
 again. If I was unclear in the summary, then please ask where you need
 further information.

 Perhaps you should look at the transports again and see how they in fact
 do not duplicate the code in WP_HTTP::request() since it would lengthen
 the methods unnecessary. It has been a point of contention that you really
 can't call individual transports, because the majority of the processing
 in WP_HTTP::request() is not found in any of the other transports.

 I mean, I'm not going to update the patch, so if you wish to close it for
 that reason, then go ahead. However, it is advised in case someone else
 wishes to support this to give proper explanation. Also performance will
 be negligible or at least normal overhead given using objects.

 '''TL;DR''' Reopening ticket because reason for closing is not supported
 by fact.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13777#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software