[wp-trac] [WordPress Trac] #16695: quicktags needs some refactoring

[WordPress Trac]

#16695: quicktags needs some refactoring
----------------------------------------------+----------------------------
 Reporter:  garyc40                           |       Owner:  scribu
     Type:  enhancement                       |      Status:  reviewing
 Priority:  normal                            |   Milestone:  Awaiting
Component:  Editor                            |  Review
 Severity:  normal                            |     Version:  3.1
 Keywords:  has-patch dev-feedback 3.2-early  |  Resolution:
----------------------------------------------+----------------------------

Comment (by garyc40):

 Providing backward compatibility is not hard. I was thinking about
 including it in my patch, but didn't have time to get around to it. We can
 always restore the global variables edButtons, as well as the edButton
 class (which will be a wrapper of the TagButton class).

 Also, personally, I didn't consider the current way of adding quick tag
 button as in the article above an API. It's more like a hack.

 I actually don't think this is over-engineering. Big change, yes. A bit
 harder to inherit and extend, yes. But if we have a chance to refactor it
 this time, why don't we do it right?

 To make it easier for devs to inherit and extend base classes, we can
 always provide another abstraction layer like prototype does with
 `Class.create()` or `Object.extend()`. But that would make quicktags less
 lightweight.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16695#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software