[wp-trac] [WordPress Trac] #16918: Take out unnecessary compat functions from compat.php

[WordPress Trac]

#16918: Take out unnecessary compat functions from compat.php
----------------------------+------------------
 Reporter:  markjaquith     |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.2
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------

Comment (by hakre):

 In #16932, looking into add_query_arg() and friends I've been running over
 _http_build_query() again.

 In this ticket we said, it's compat to
 [http://www.php.net/manual/en/function.http-build-query.php
 http_build_query()], but it's not. The $key parameter is undefined and the
 $urlencode parameter is undefined.

 It looks like that _http_build_query() has been designed pre 5.3.6 (makes
 sense) and that it's overloading optional parameters that are now used in
 a different context and therefore render the compat function incompatible.

 The udpated patch reflects that for that one call.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16918#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software