[wp-trac] [WordPress Trac] #9064: URLs with commas are not pinged

[WordPress Trac]

#9064: URLs with commas are not pinged
------------------------------+-----------------------------
 Reporter:  sirzooro          |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  high              |   Milestone:  Future Release
Component:  Pings/Trackbacks  |     Version:  2.7
 Severity:  major             |  Resolution:
 Keywords:  needs-patch       |
------------------------------+-----------------------------

Comment (by hakre):

 Replying to [comment:1 tomontoast]:
 > If this piece of code does what I think it does then the charcahters
 *'()_ should also be included as valid punctuation in urls. See
 [http://www.ietf.org/rfc/rfc1738.txt]

 Right, [http://tools.ietf.org/html/rfc1738#section-2.2 rfc1738 Section
 2.2] specifies the following characters as part of URLs:

 {{{
 ";", "/", "?", ":", "@", "=" and "&"
 "$-_.+!*'(),"
 }}}

 And in one list:

 {{{
 ;/?:@=&$-_.+!*'(),
 }}}


 ----

 Replying to [comment:18 dd32]:
 > > comment.php.diff
 >
 > That seems to be the most straight forward method here, Clickable and
 non-clickable links should be pung IMO.

 The make_clickable() function has some advanced regexes to offer, I assume
 because of it's longer history of changes: #14993, #11211, #10990, #8300,
 #5081 and #3228. Probably that's something to connect to, subject to
 change, see #16892.

 >
 > Thats also the only proposed solution here which ignores trailing
 commas, "http://test.com/, something else" shouldn't match that comma.
 >
 > Adding the other punctuation markers here (Well, underscore is already
 supported) specifically the ()'s could be tricky, (http://.../) vs
 http://wikipedia/some_article(other_ambiguation) doesnt match the 2nd
 properly - There are other parts of WordPress which suffer(or have
 suffered) that problem.

 I think make_clickable() deals with all that. We have regexes and callback
 functions already (Related: #16892).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/9064#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software