[wp-trac] [WordPress Trac] #16891: Deleting all attachments from post under 'Gallery' tab shows 'From Computer' tab sans uploader

[WordPress Trac]

#16891: Deleting all attachments from post under 'Gallery' tab shows 'From
Computer' tab sans uploader
------------------------------------+------------------------------
 Reporter:  kawauso                 |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Media                   |     Version:  3.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------
Changes (by garyc40):

 * keywords:  needs-patch => has-patch dev-feedback
 * component:  Administration => Media


Comment:

 [attachment:16891.diff Patch attached] that fixes the following problems:

 - When there's no item in the gallery, the action "media_upload_gallery"
 is fired before we actually check whether there should be a Gallery tab or
 not. As a result, when you delete everything, you get redirected to a page
 where there is no "Gallery" tab, but the Gallery list table is displayed.

 - When you upload images, then Save all changes, and proceed to delete one
 of them, somehow you got redirected to "From Computer" tab. The expected
 behavior is redirecting to Gallery tab instead. The fix is included in the
 patch I attached.

 Can someone please confirm if this is a regression?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16891#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software