[wp-trac] [WordPress Trac] #16884: str_replace() in setup-config's get_bloginfo() is bogus

WordPress Trac wp-trac at lists.automattic.com
Fri Mar 18 20:35:29 UTC 2011


#16884: str_replace() in setup-config's get_bloginfo() is bogus
------------------------------------+------------------------------
 Reporter:  hakre                   |       Owner:
     Type:  defect                  |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  General                 |     Version:  3.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------

Comment (by hakre):

 Replying to [comment:13 nacin]:
 > It's a parameter order issue. I did subject, match, replace, instead of
 match, replace, subject.

 Thanks for clarification.

 >
 > The phpdoc allows multiple declarations to all take the same phpdoc. I'm
 not sure it's necessary here as it is one function.

 Ah, cool.


 ----


 As the parameter issue could be clarified, this clarified the use of the
 str_replace statement as well.

 I created another patch that is making use of the wp_guess_url() function
 as it is used to populate `get_option( 'home' )` on install. It's
 available through `/wp-includes/functions.php`
 ([http://wordpress.stackexchange.com/questions/12389/on-install-which-
 code-sets-the-home-option thx t31os]).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16884#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list