[wp-trac] [WordPress Trac] #11557: HTTP Streams transport doesnt abide max redirection

[WordPress Trac]

#11557: HTTP Streams transport doesnt abide max redirection
-------------------------------------+---------------------
 Reporter:  dd32                     |       Owner:  dd32
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  3.0
Component:  HTTP                     |     Version:  2.9
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |
-------------------------------------+---------------------

Comment (by hakre):

 Replying to [comment:3 dd32]:
 > > It (the 1) could be read as: The first redirect is max, so it won't be
 done.
 >
 > Another way to look at it, Like in my OP, Is that the max_redirections
 is actually The maximum number of ''requests'' it will make. So 1 request,
 and result is a 30x, Has hit the maximum limit count.

 But how would you explain the 0 value then? To do no request at all?
 Additionally it's called "Redirect" and not "Request" in that switches
 name, so seeing redirects as request looks highly subjective to me.

 > > Is there a documentation of the request() $args array members
 available?
 > Its in the file. If its not there, Then probably not. Look at
 WP_HTTP::request() perhaps. But reading the code is the best method.

 Right now on top of the file in the base class there is much more text,
 but it does not contains much more info.

 >
 > > what about setting the default value to 20?
 > Thats completely irrelivant to this ticket.

 Right, see Related: #16887

 > As a test, Try requesting http://tools.dd32.id.au/redirect/?rt=5 which
 makes 5 redirects with the various transports. All of them except streams
 will suceed in requesting the document. Increase {{{redirection}}} to 6
 and all will suceed. Decrease {{{redirection}}} to 4 and all will fail.

 Works, but you should filter the input to not-too-large, positive integer
 values.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11557#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software