[wp-trac] [WordPress Trac] #16881: Remove all unwanted 'nofollow' attributes from 'reply to comment' links

WordPress Trac wp-trac at lists.automattic.com
Thu Mar 17 20:27:43 UTC 2011


#16881: Remove all unwanted 'nofollow' attributes from 'reply to comment' links
--------------------------+------------------------------------
 Reporter:  joelhardi     |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Comments      |    Version:  3.1
 Severity:  minor         |   Keywords:  dev-feedback has-patch
--------------------------+------------------------------------
 This should be a trivial fix. r16230 removed the rel="nofollow" attribute
 from "reply to comment" links in the comments list, for reasons discussed
 in #10550. In brief, the reasons are that these are not external links
 that we want to tell search engines not to follow in the first place, and
 there is actually an SEO penalty from adding the "nofollow" to internal
 links.

 Unfortunately, the "nofollow" was not removed from all of the "reply to
 comment" and "reply to post" links (for instance, in code branches when
 the site requires login/registration to comment). This patch corrects the
 rest of them.

 It doesn't delete the "nofollow" attributes we want. For instance, in
 `get_comment_author_link()` which escapes links to the comment author's
 URL.

 Additionally, the patch (see line 1110) fixes a minor inconsistency
 between the return values of `get_comment_reply_link()` and
 `get_post_reply_link()` when `get_option('comment_registration')` is TRUE.

 The version in `get_post_reply_link()` is missing the `class="comment-
 reply-login"` and `esc_url()` wrap. I've added them.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16881>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list