[wp-trac] [WordPress Trac] #16879: bug in function wp_count_comments in wp-includes/comment.php line 900

[WordPress Trac]

#16879: bug in function wp_count_comments in wp-includes/comment.php line 900
--------------------------+-----------------------------
 Reporter:  tfnab         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Comments      |    Version:  3.1
 Severity:  trivial       |   Keywords:  has-patch
--------------------------+-----------------------------
 This seems to have been around for a while and keeps being ignored, or
 rather pushed back, by Mark Jaquith, with phony arguments. Please re-
 consider just patching this!!! It's really trivial.

 See tickets #16446 and #15215, both on WP3.0, for one possible solution.

 I'd actually like to propose another approach: the $known_types array is
 not needed, because instead of inarray($x,array_keys($y)) one can use
 isset($y[$x]) -- see my patch.

 Mark: you're basically saying, that there are other things that should
 keep us from using a custom comment status in a plugin. Well, if we can
 live with it, why do you still practically force us to edit core and make
 keeping our blogs up-to-date with the latest WordPress updates such a big
 pain?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16879>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software