[wp-trac] [WordPress Trac] #16717: Wrong error handling in query.php::get_posts()

[WordPress Trac]

#16717: Wrong error handling in query.php::get_posts()
--------------------------+-----------------------
 Reporter:  fabifott      |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.1.1
Component:  Query         |     Version:  3.1
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by hakre):

 The ticket here is basically a duplicate of #16464. In #16464 we came to
 the conclusion that get_term_by() should not return WP_Error on error but
 FALSE (as documented).

 Previous to that conclusion there was an earlier suggestion was to check
 for WP_Error (comparable to the changesets [17506] and [17507]) and the
 ticket had such a patch for weeks already (it was with a minor error which
 didn't get corrected because core developer feedback pointed out that the
 other patch is preferred).

 That ticket had been put to Future Release ca. 4 weeks ago.

 The new patch here is the solution of #16464 for current trunk (and it
 probably applies on to 3.1 branch as well.

 Please review.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16717#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software