[wp-trac] [WordPress Trac] #12307: files missing closing php tags

[WordPress Trac]

#12307: files missing closing php tags
-----------------------------+-----------------------------
 Reporter:  washer           |       Owner:  nacin
     Type:  defect (bug)     |      Status:  accepted
 Priority:  lowest           |   Milestone:  Future Release
Component:  General          |     Version:  2.9.2
 Severity:  trivial          |  Resolution:
 Keywords:  has-patch early  |
-----------------------------+-----------------------------

Comment (by toscho):

 Replying to [comment:19 RyanMurphy]:
 > Replying to [comment:18 toscho]:
 > > wp-includes/default-filters.php has a blank line after the closing
 tag. Is that intended?
 >
 > I don't see a blank line after the closing tag - I do see one between
 the last command and the tag though.

 Oh, sorry, I shouldn’t rely on SVN. The Subclipse plugin is adding blank
 lines. Dangerous.

 > IMO, they do add value, in that you know you have the full file. When I
 was making the patch, I had to look at some of the files in the trac
 browser to make sure I had the full file, because where it ended didn't
 look right.

 That’s probably a question of style. When I see a closing tag, I expect
 some output afterwards.
 Shouldn’t diff show you if the patch is complete?

 > If we don't want to use the PHP closing tag, we should at least add a
 comment, like I did with wp-config-sample.php.

 I don’t see such a comment in
 [http://core.trac.wordpress.org/browser/trunk/wp-config-sample.php wp-
 config-sample.php]?

 `#!end` :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/12307#comment:20>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software