[wp-trac] [WordPress Trac] #13958: Deactivating custom post types/taxonomies breaks nav menus

[WordPress Trac]

#13958: Deactivating custom post types/taxonomies breaks nav menus
--------------------------+------------------------
 Reporter:  WraithKenny   |       Owner:  ocean90
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  3.2
Component:  Menus         |     Version:  3.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------
Changes (by ocean90):

 * keywords:  has-patch commit => has-patch


Comment:

 ''13958.3.patch''
  - We don't need to set ''post_status'', as nacin mentioned ''(Pending)''
 is only for non-JS mode, also it's not pending it's invalid.

   Side effect was also if you set post_status to draft that you will get
 the "Click Save Menu to make pending menu items public." message. So just
 remove the both lines.

  - comment:35: I noticed that we can't do this check, because we are using
 [http://core.trac.wordpress.org/browser/trunk/wp-admin/nav-menus.php#L327
 ''publish'' in the admin too]. Solution is, too use {{{! is_admin()}}}.

  - I added to the patch also a small message if
 {{{$some_invalid_menu_items}} exists, same as
 {{{$some_pending_menu_items}}}. String needs a review.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13958#comment:37>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software