[wp-trac] [WordPress Trac] #17748: Twenty Eleven code review & consistancy

[WordPress Trac]

#17748: Twenty Eleven code review & consistancy
---------------------------+------------------
 Reporter:  dd32           |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.2
Component:  Bundled Theme  |     Version:  3.2
 Severity:  normal         |  Resolution:
 Keywords:                 |
---------------------------+------------------

Comment (by dd32):

 * showcase.php - [http://core.trac.wordpress.org/browser/trunk/wp-
 content/themes/twentyeleven/showcase.php#L131 Requeries $featured_args]
 for no apparent reason
  * showcase.php - uses a counter to output a list, could just do an if and
 then a while. Also leaves a </ol> stranded if there are no posts.. which
 is unlikely
  * showcase.php - {{{s/<b>/<strong>/g}}} ? (in the Commenting strings)
  * showcase.php again - {{{$xx = new WP_Query(); $xx->query($args);  =>
 $xx = new WP_Query( $args );}}}

 I'm not coding everything as I run across it to avoid stomping on feet and
 leaving a huge patch on someones morning email, I'm happy to deal with
 most of the changes here if someone would like to confirm the expected
 behaviour on most of the items. Unless there are any objections, I'll work
 on a patch for cleaning up the PHP tomorrow (ie. 12hours from now) which
 is separate from the consistency issues outlined above.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17748#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software