[wp-trac] [WordPress Trac] #17682: Browser nag PHP Notice if no user agent is set

[WordPress Trac]

#17682: Browser nag PHP Notice if no user agent is set
------------------------------+------------------
 Reporter:  duck_             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.2
Component:  Warnings/Notices  |     Version:  3.2
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------

Comment (by aaroncampbell):

 I had worked up a patch too.  Attaching just in case.  It looks like the
 main difference is that in `wp_dashboard_browser_nag` I wrapped all of the
 content creating in an `if( $response )` since it uses $response a couple
 times in content creation.  If we go witht eh .2 patch from duck we need
 to check the variables being passed into the sprintf as well.  My patch
 simply passes an empty string to the `browse-happy-notice` filter if
 `wp_check_browser_version()` returns false.

 I also added @return docs, but I didn't catch the 3.2.0 vs 3.2 thing, so
 if we go with my patch we should probably add that.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17682#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software