[wp-trac] [WordPress Trac] #16432: Hexadecimal entity support within ent2ncr

WordPress Trac wp-trac at lists.automattic.com
Fri Jun 3 10:44:06 UTC 2011


#16432: Hexadecimal entity support within ent2ncr
-------------------------------------+------------------------------
 Reporter:  GaryJ                    |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  General                  |     Version:  3.1
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------
Changes (by GaryJ):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 Two patches - the first is a simple filter on the return value.

 The second patch approaches it a slightly different way. The issue with
 the first, is that for a block of text that is being running through
 `ent2ncr()`, all of the string replacements would still be done, even if
 they weren't then used in the plugin filter function. By letting the
 plugin short circuit the function (if something truthy is being returned
 from the plugin filter function, return that from `ent2ncr()`
 immediately), it improves performance.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16432#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list