[wp-trac] [WordPress Trac] #17644: DFW needs to use theme-defined editor styles

WordPress Trac wp-trac at lists.automattic.com
Wed Jun 1 18:44:47 UTC 2011


#17644: DFW needs to use theme-defined editor styles
--------------------------+------------------
 Reporter:  markjaquith   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.2
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  ux-feedback   |
--------------------------+------------------

Comment (by azaozz):

 Replying to [comment:8 nacin]:
 > This was discussed ad nauseam and decided on in a dev chat like a month
 ago.

 Yes, I remember some discussions there but think it was decided to not let
 the theme set background-color, color, body width, etc. i.e. any styles
 that would break DFW (or perhaps I missed it).

 > If anything, JavaScript should detect the background color defined by
 editor-style.css and set the rest of the canvas to the same color.

 This is probably doable. Would have to change all colors in DFW: toolbar,
 word count, etc. But what about switching to the HTML editor in DFW? Are
 we resetting all colors to default (as themes don't style the HTML editor)
 or are we keeping all changed colors?

 > Otherwise, DFW should accept editor-style.css completely. There should
 also be a way to target, via CSS alone, DFW in editor-style.css. That way
 using a single stylesheet, someone can offer editor styles that are
 tweaked for DFW vs Visual.

 Accepting editor-style.css completely may change DFW drastically making it
 distracting, show horizontal scrollbar, etc. The problem is that some
 themes would need to be upgraded in order to work properly there. So the
 question is: do we make DFW work everywhere or let it break/look bad for
 themes that are very aggressive in styling the editor.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/17644#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list