[wp-trac] [WordPress Trac] #18289: Direct link to plugin installation should have admin chrome

WordPress Trac wp-trac at lists.automattic.com
Sat Jul 30 20:50:06 UTC 2011

#18289: Direct link to plugin installation should have admin chrome
 Reporter:  nacin            |       Owner:  nacin
     Type:  task (blessed)   |      Status:  reviewing
 Priority:  normal           |   Milestone:  3.3
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |
Changes (by csixty4):

 * owner:   => nacin
 * status:  new => reviewing


 The attached patch adds this functionality. Just add "&wrapped" to the end
 of the query string.

 Couple concerns I have:

 * install_plugins_pre_plugin-information is already an action. To get a
 return value, I had to make it a filter. Didn't want to break existing
 plugins, so now it's an action AND a filter, with one called instead of
 the other if iframed. Kinda redundant. Is it worth adding a separate
 filter for this, or maybe deprecating the action?

 * Lots of HTML mixed with code in wp-admin/includes/plugin-install.php.
 Any chance a templating system could be used here?

Ticket URL: <http://core.trac.wordpress.org/ticket/18289#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list