[wp-trac] [WordPress Trac] #18236: Change hook 'post_edit_form_tag' from an action to a filter

WordPress Trac wp-trac at lists.automattic.com
Fri Jul 29 05:59:01 UTC 2011


#18236: Change hook 'post_edit_form_tag' from an action to a filter
--------------------------+------------------------------
 Reporter:  mikeschinkel  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Upload        |     Version:  3.2.1
 Severity:  normal        |  Resolution:
 Keywords:  close         |
--------------------------+------------------------------
Changes (by nacin):

 * keywords:  dev-feedback => close


Comment:

 Replying to [comment:3 mikeschinkel]:
 > Only if you know what actions to remove and which ones not to remove.
 Who knows what some plugin is doing as a side-effect in their
 `'post_edit_form_tag'`?

 Don't see the difference between the status quo -- needing to remove
 everything -- than the proposed change, which not only will require
 parsing whatever earlier filters have added, but also what back-compat
 actions have been added, as well as priorities because later actions will
 override things (in a much different way than filter followed by filter
 would). I prefer this as an action. Not a filter.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18236#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list