[wp-trac] [WordPress Trac] #18263: Doing it Wrong for Taxonomies

[WordPress Trac]

#18263: Doing it Wrong for Taxonomies
------------------------------+------------------------------
 Reporter:  WraithKenny       |       Owner:
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Warnings/Notices  |     Version:  3.2.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------------------
Changes (by WraithKenny):

 * status:  closed => reopened
 * resolution:  duplicate =>


Comment:

 Related to #12917 which is marked invalid, so I assume from Nacin's
 comment that fixing the Media Library so `type` can be registered as a
 taxonomy is the way to go? `type` does seem to be the lone term that
 causes issues. Regardless, the code dealing with that ticket's issue has
 been removed from these newer patches.

 Related to #15824 which is set to fixed so I had assumed opening new
 tickets for new `_doing_it_wrong` calls. I'm reopening this one with that
 in mind.

 As for the tabs: I'm hoping that since I've only tabbed 2 deep this time,
 it shouldn't be a problem :-)

 I had included the core-registered taxonomies merely for completeness (and
 notice for the `type` issue), which is removed in the newer patches. The
 check for `_builtin` prevents `trigger_error` against core registrations.
 The list is pulled only from the query vars now.

 I had occurred to me after work, that plugins that register the same
 taxonomy twice would receive the error (via `public_query_vars`), and it
 wouldn't make sense.

 `tax-doin-wrong-3.patch` prevents `trigger_errors` on twice registered
 taxonomies at the cost of a global. (I left the global in my code block
 for review, but I can resubmit the patch with it at the top of the
 function.)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18263#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software