[wp-trac] [WordPress Trac] #18263: Doing it Wrong for Taxonomies

WordPress Trac wp-trac at lists.automattic.com
Wed Jul 27 00:39:54 UTC 2011


#18263: Doing it Wrong for Taxonomies
------------------------------+------------------------------
 Reporter:  WraithKenny       |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Warnings/Notices  |     Version:  3.2.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------------------

Comment (by Viper007Bond):

 Some patch feedback I wrote before I saw nacin's reply but that I'm
 posting anyway:

 * Tabs shouldn't be used inline. Look how weird that array looks in Trac.
 Your tab sizes are different than what Trac and my text editor uses. ;)
 Simple solution is to just add a line break before the first item which
 the standard way in !WordPress:

 {{{
 $foo = array(
         'item1',
         'item2',
 );
 }}}

 * It doesn't seem like a good idea for maintainability reasons to keep a
 separate list of built-in taxonomies. It'd be better to dynamically build
 this list.

 * The code for generating the list for the Codex shouldn't go into core.
 It's trivial to create by hand and the code could instead be stored
 somewhere on the Codex.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18263#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list