[wp-trac] [WordPress Trac] #18218: Too many similar translation string
WordPress Trac
wp-trac at lists.automattic.com
Mon Jul 25 16:18:07 UTC 2011
#18218: Too many similar translation string
-------------------------+------------------------------
Reporter: ramiy | Owner:
Type: enhancement | Status: reopened
Priority: normal | Milestone: Awaiting Review
Component: I18N | Version: 3.2.1
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------------------
Comment (by SergeyBiryukov):
While most of the replacements are valid, there are a couple changes in
[attachment:18218.4.patch 18218.4.patch] that don't seem neccessary.
Like in `class-wp-posts-list-table.php`, where we replace a more
meaningful string with a more generic one:
{{{
title="' . esc_attr( __( 'Edit this item inline' ) ) . '">' . __(
'Quick Edit' ) . '</a>'
title="' . esc_attr( __( 'Quick Edit' ) ) . '">' . __( 'Quick Edit' ) .
'</a>'
}}}
And we get exactly the same strings in anchor name and title, which is
against #16783.
Or in `internal-linking.php`:
{{{
_e( 'Open link in a new window/tab' );
_e( 'Open link in a new window' );
}}}
I guess most of the time `target="_blank"` links are opened in a new tab,
not a window.
That's why I believe westi is right about the step-by-step approach.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18218#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list