[wp-trac] [WordPress Trac] #16282: PHP catchable error with get_term_link and WP3.1RC2

WordPress Trac wp-trac at lists.automattic.com
Mon Jan 24 02:48:02 UTC 2011


#16282: PHP catchable error with get_term_link and WP3.1RC2
------------------------------+-----------------------
 Reporter:  illutic           |       Owner:
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  3.1
Component:  Multisite         |     Version:  3.1
 Severity:  major             |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------

Comment (by dd32):

 > The correct solution would be to have two versions of get_term_by(): one
 for WP_Query, that uses sanitize_title_for_query() and one for
 get_term_link() which uses sanitize_title() nothing.

 After reading that ticket earlier, It just made me even more confused why
 you replaced it with sanitize_title_for_query() in that spot.

 In the case of Term slugs, µ is sanitized to u (as sanitize_title does on
 pre_term_save), not sanitized to '%c2%b5' like sanitize_title_for_query().

 Perhaps, it's just that sanitize_title_for_query() needs to use
 remove_accents() as well.

 What does that changeset actually allow? Looking at that ticket, that
 commit was after it was decided it was 3.2 material, and being that it's
 caused this regression..

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16282#comment:32>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list