[wp-trac] [WordPress Trac] #16282: PHP catchable error with get_term_link and WP3.1RC2

[WordPress Trac]

#16282: PHP catchable error with get_term_link and WP3.1RC2
--------------------------+------------------
 Reporter:  illutic       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.1
Component:  Multisite     |     Version:  3.1
 Severity:  major         |  Resolution:
 Keywords:  close         |
--------------------------+------------------
Changes (by nacin):

 * keywords:  2nd-opinion => close


Comment:

 I went to go find the other ticket I recently saw on this, but then I
 realized it was this ticket.

 So:

  - Fix the inline docs. get_term_link() has been able to return WP_Error
 for quite a while.

  - The reporter may wish to look into what the WP_Error is saying, and why
 the term no longer exists (presumably). Does not look like a core issue.

  - I kind of like get_post_format_link() avoiding WP_Error. That's because
 it might be used in a theme for one of the defined formats, but it might
 not yet exist as a term since no posts have been assigned to it. Easier to
 return nothing rather than fatal. It also doesn't take a term, but rather
 a specific format -- so it could be considered at a higher level in the
 API.

 Therefore:

  - I'm committing the patch here and suggest we close as fixed.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16282#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software