[wp-trac] [WordPress Trac] #16057: download_url() error checking fails to notice that the file wasnt correctly witten to disk

[WordPress Trac]

#16057: download_url() error checking fails to notice that the file wasnt correctly
witten to disk
-----------------------------------------------+---------------------------
 Reporter:  dd32                               |       Owner:
     Type:  defect (bug)                       |      Status:  new
 Priority:  normal                             |   Milestone:  Future
Component:  Upgrade/Install                    |  Release
 Severity:  normal                             |     Version:  3.0
 Keywords:  has-patch needs-testing 3.2-early  |  Resolution:
-----------------------------------------------+---------------------------

Comment (by dd32):

 > attachment 16057.2.diff  added

  * Checks to make sure temporary files are written correctly before being
 transferred to the FTP Server
  * Checks to see files written directly finish writing properly
  * '''Note: file_put_contents()''' seems to be unaffected, returns false
 on failure in all cases, (int)$bytes_written on success. Given it's
 PHP5-only, it'd probably be wise to switch to that if at all possible in
 some locations

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16057#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software