[wp-trac] [WordPress Trac] #15503: Disable buttons for pagination
WordPress Trac
wp-trac at lists.automattic.com
Sat Jan 1 23:02:45 UTC 2011
#15503: Disable buttons for pagination
------------------------------------------+-----------------------
Reporter: batmoo | Owner: nacin
Type: enhancement | Status: accepted
Priority: normal | Milestone: 3.1
Component: Administration | Version: 3.1
Severity: normal | Resolution:
Keywords: has-patch needs-ui 3.2-early |
------------------------------------------+-----------------------
Comment (by nacin):
I don't like the span/a toggle here. Just stick to links and make the
links noop. I'm just not interested in avoiding an anchor in non-JS
situations -- it makes the code too convoluted.
I've patched this using a minimal amount of code, but I think I've picked
up on the same bug gary did, "also properly update href attributes when
changing pages", which I can see in a browser that doesn't support
pushState (i.e. Firefox 3.6.13). Basically, the next link reflects paged=2
even though I'm on page 38 of 39. The link does take me to page 39 though.
I'm committing my fix for now as it isn't a regression. We might need some
massaging to fix that related bug, if it is indeed an issue we should be
concerned with. Minimal code churn is important.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/15503#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list